11

This reopen queue review has received 6 leave closed reviews, one from a mod, but the review is still active.

2

2 Answers 2

9

This was one of the more complicated bugs I have ever encountered!

This issue was caused by our 'Leave Closed' modal being able to be submitted after selecting 'This question doesn't meet a [Community Specific] guideline' without additionally selected a community specific reason in the following modal when casting a vote that should close the review.

In this specific case this appears to have happened with the original moderator vote, which should have closed the review but did not because of the lack of a community specific reason. This meant that the subsequent votes from non-moderators were not recorded as terminal votes because preference was given to the existing moderator vote. That is why the review did not close until another moderator came and, in essence, overrode the original moderator vote.

While debugging this, I thoroughly searched for other examples of a review entering the same broken state because of a terminal vote being cast without a community specific reason and managed to find about 10 other instances where the same thing happened. I was unable to find a corresponding report for those instances, so thank you all for bringing this to our attention!

This issue should be resolved as of today, with multiple checks now in place to prevent a community specific vote being cast without a community specific reason. I have also updated the leave closed modal so that it clears your reason and your community specific reason upon exiting so that there is always a clean slate when you open the modal.

2
7

Turns out the 9th vote is the charm.

Either that or I've got super duper mod powers

Timeline of post

1
  • 1
    Really bizarre. I wonder if something was posted about this. I vaguely remember hearing something (or I'm imagining it).
    – Timmy Jim Mod
    Commented Oct 18, 2022 at 10:38

You must log in to answer this question.

Not the answer you're looking for? Browse other questions tagged .